]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
workspaceThumbnails: Add missing return values to later handlers
authorFlorian Müllner <fmuellner@gnome.org>
Mon, 3 Nov 2025 11:50:34 +0000 (12:50 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Mon, 3 Nov 2025 12:21:46 +0000 (13:21 +0100)
MetaLaters are source functions, and should therefore return a bool
to indicate whether the source should be removed or continue.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3950>

js/ui/workspaceThumbnail.js

index 6bd834407d3c6d997754e5aa528a114332e6cd25..40ac3630791dc6604acfc2de11a147f41da0a98e 100644 (file)
@@ -1188,7 +1188,10 @@ export const ThumbnailsBox = GObject.registerClass({
 
         const laters = global.compositor.get_laters();
         this._updateStateId = laters.add(
-            Meta.LaterType.BEFORE_REDRAW, () => this._updateStates());
+            Meta.LaterType.BEFORE_REDRAW, () => {
+                this._updateStates();
+                return GLib.SOURCE_REMOVE;
+            });
     }
 
     _unqueueUpdateStates() {
@@ -1345,6 +1348,7 @@ export const ThumbnailsBox = GObject.registerClass({
                     Meta.LaterType.BEFORE_REDRAW, () => {
                         this._dropPlaceholder.hide();
                         delete this._dropPlaceholderLater;
+                        return GLib.SOURCE_REMOVE;
                     });
             }
         }
@@ -1381,6 +1385,7 @@ export const ThumbnailsBox = GObject.registerClass({
                         Meta.LaterType.BEFORE_REDRAW, () => {
                             this._dropPlaceholder.show();
                             delete this._dropPlaceholderLater;
+                            return GLib.SOURCE_REMOVE;
                         });
                 }
                 x += placeholderWidth + spacing;